fix: console servicemonitor labels improved #131
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qboileau
reviewed
Nov 18, 2024
Comment on lines
+8
to
+9
| {{- $labels := include "common.tplvalues.merge" ( dict "values" ( list .Values.platform.metrics.serviceMonitor.labels .Values.commonLabels ) "context" . ) }} | ||
| labels: {{- include "common.labels.standard" ( dict "customLabels" $labels "context" $ ) | nindent 4 }} |
There was a problem hiding this comment.
do we have the same label rendering issue for other resources as well ? if yes, can you include fix for other resources labels in this PR please ?
|
After further inspection I noticed this issue had already been addressed by #122 which was merged on the 17th Oct. Our latest release |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for labels' parse when the chart is referenced as a dependency or sub-chart (i.e. umbrella chart)
Resolves #128