Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update commands in the kbs cluster documentation #473

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

GabyCT
Copy link
Contributor

@GabyCT GabyCT commented Aug 21, 2024

This PR update commands in the kbs cluster documentation to avoid failures with the current command that it has.

This PR update commands in the kbs cluster documentation to avoid
failures with the current command that it has.

Signed-off-by: Gabriela Cervantes <gabriela.cervantes.tellez@intel.com>
Copy link
Member

@Xynnn007 Xynnn007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix. docker compose and docker-compose both exist, but seems that docker-compose has been merged into docker.

@@ -18,14 +18,15 @@ Users can use very simple command to:

Generate a user auth key pair
```
cd $KBS
git clone https://github.com/confidential-containers/trustee.git
cd kbs
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a typo?

Suggested change
cd kbs
cd trustee

@mythi
Copy link
Contributor

mythi commented Aug 22, 2024

Thanks for the fix. docker compose and docker-compose both exist, but seems that docker-compose has been merged into docker.

See #455 (I think this PR shoud set Fixes: ...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants