Fix async producer transaction behavior + add transactional produce benchmark test #2072
+867
−355
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Key Changes
AIOProducer Transaction Fixes
commit_transaction()
: add callawait self.flush()
before committing to ensure both Python-layer buffer and librdkafka queue are flushed. Previously the Python-layer batch_processor buffer was not flushedabort_transaction()
: similarly, add callawait self.purge()
to cancel pending futures and clear Python-layer bufferProducer Strategy Transaction Support
Transaction Performance Testing
test_basic_produce_with_transaction
benchmark test (per-message transaction) for sync vs asynctransaction_benchmark_bounds.json
File Organization
benchmark_metrics.py
→producer_benchmark_metrics.py
,benchmark_bounds.json
→producer_benchmark_bounds.json
for consistencyChecklist
References
JIRA:
Test & Review
Open questions / Follow-ups