Fix formatting issue of TopicPartition that causes SystemError on Windows #2141
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.





What
Minor fix to address the formatting issue of TopicPartiton:
CFL_PRId32macro expands to "I32d" on Windows (MSVC), which is not supported by Python's PyUnicode_FromFormat(). To fix it, we will replaceCFL_PRId32with%d. This is safe as partition is already declared as int in the structChecklist
References
Issue: #1715
Jira: https://confluentinc.atlassian.net/browse/NONJAVACLI-4144
Test & Review
Open questions / Follow-ups