Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ST-3880] update properties template to included addition monitoring properties #29

Open
wants to merge 2 commits into
base: 5.4.x
Choose a base branch
from

Conversation

sdandu-gh
Copy link

@sdandu-gh sdandu-gh commented Jun 8, 2020

Currently there are properties that don't map correctly in docker template by default based on available parameters per the docs:
https://docs.confluent.io/current/control-center/installation/configuration.html#monitoring-settings

Specifically missing:
confluent.monitoring.interceptor.topic.replication
confluent.monitoring.interceptor.topic.skip.backlog.minutes

Testing:

Verified that properties file in image shows:
confluent.monitoring.interceptor.topic.skip.backlog.minutes=20
confluent.monitoring.interceptor.topic.replication=2

after setting:
CONTROL_CENTER_MONITORING_INTERCEPTOR_TOPIC_REPLICATION: 2
CONTROL_CENTER_MONITORING_INTERCEPTOR_TOPIC_SKIP_BACKLOG_MINUTES: 20

Signed-off-by: sdanduConf <sdandu@confluent.io>
@sdandu-gh sdandu-gh requested a review from xli1996 June 8, 2020 06:55
Signed-off-by: sdanduConf <sdandu@confluent.io>
@sdandu-gh
Copy link
Author

We could additionally add the following to be more forward looking (if we expect additional confluent.monitoring properties. It would result in including both confluent.controlcenter.monitoring and confluent.monitoring unless we explicitly exclude though:

{# NOTE: the env var prefix is CONTROL_CENTER_MONITORING_ but the property prefix is confluent.monitoring. #}
{% set monitoring_props = env_to_props('CONTROL_CENTER_MONITORING_', 'confluent.monitoring.', exclude=excludes) -%}
{% for name, value in monitoring_props.items() -%}
{{name}}={{value}}
{% endfor -%}

@sdandu-gh sdandu-gh changed the title update properties template to included addition monitoring properties [ST-3880] update properties template to included addition monitoring properties Jun 8, 2020
Copy link
Member

@xli1996 xli1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, srini, in addition I think there might be a gap of configuration between product repos and docker image repos, we have another similar issue in kafka images as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants