-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding int identifier for transactional ID #4803
Adding int identifier for transactional ID #4803
Conversation
/sem-approve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Style check and tests are failing. Please fix those.
To fix style check, run make style-check-changed
for the changed code. Note that the change code is uncommitted code.
/sem-approve |
/sem-approve |
I mean, the style check I ran the command to fix that locally so I don't know what else to do here :/ Any suggestions? |
The style check works with uncommitted and unstaged changes. Can you try to uncommit your changes and then run Test still fails. Failing on different architecture is not related to the test cases. Its something else that I can check later when the style check and tests passes. Please focus on the |
Closing this PR. |
Adding the int ID for transactional ID, to enable using that as a ResourceType in the clients (python being my use-case specifically)