-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fallback to fetch v12 (#10) #4806
base: master
Are you sure you want to change the base?
Conversation
If any toppars have a zero topic id
@@ -943,7 +943,21 @@ static void rd_kafka_broker_fetch_reply(rd_kafka_t *rk, | |||
} | |||
} | |||
|
|||
/** | |||
* @brief Check if any toppars have a non-zero topic id. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will change to zero topic id
rkbuf = rd_kafka_buf_new_flexver_request( | ||
|
||
/* Fallback to version 12 if topic id is null which can happen if | ||
* inter.broker.protocol.version is old */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change old to <2.8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix! Let's make your changes and my comment and rebase it, then I'm approving
* @brief Check if any toppars have a non-zero topic id. | ||
* | ||
*/ | ||
rd_bool_t can_use_topic_id(rd_kafka_broker_t *rkb) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add static, better calling it can_use_topic_ids
(as in J)
rd_bool_t can_use_topic_id(rd_kafka_broker_t *rkb) { | |
static rd_bool_t can_use_topic_ids(rd_kafka_broker_t *rkb) { |
If any toppars have a zero topic id
How to Reproduce
Set inter.broker.protocol.version to 2.4 with 3.7 and fetch would fail always.