Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Github Issue 4142 Patch #4809

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Github Issue 4142 Patch #4809

wants to merge 1 commit into from
+2 −3

Conversation

mahajanadhitya
Copy link
Contributor

No description provided.

@mahajanadhitya mahajanadhitya requested a review from a team as a code owner August 9, 2024 09:16
emasab
emasab requested changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@emasab emasab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't the expected fix and it introduces a regression for example test 0004 leaks memory with this commit. Check issue comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emasab emasab emasab requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mahajanadhitya @emasab