Further granularity

connectrpc · Jun 17, 2024 · fe00f4b · fe00f4b
1 parent 523c7a7
commit fe00f4b
Show file tree

Hide file tree

Showing 2 changed files with 61 additions and 5 deletions.
diff --git a/.github/workflows/conformance.yaml b/.github/workflows/conformance.yaml
@@ -11,7 +11,13 @@ permissions:
 jobs:
   node:
     runs-on: ubuntu-22.04
+    strategy:
+      matrix:
+        node-version: [16, 18, 20, 21]
     steps:
+      - uses: actions/setup-node@v4
+        with:
+          node-version: ${{ matrix.node-version }}
       - name: checkout
         uses: actions/checkout@v4
       - name: cache
@@ -23,8 +29,52 @@ jobs:
           key: ${{ runner.os }}-connect-node-conformance-${{ hashFiles('Makefile') }}
           restore-keys: |
             ${{ runner.os }}-connect-node-conformance-
-      - name: testnodeconformance
-        run: make testnodeconformance
+      - name: testconnectnodeconformance
+        run: make testconnectnodeconformance
+  fastify:
+    runs-on: ubuntu-22.04
+    strategy:
+      matrix:
+        node-version: [16, 18, 20, 21]
+    steps:
+      - uses: actions/setup-node@v4
+        with:
+          node-version: ${{ matrix.node-version }}
+      - name: checkout
+        uses: actions/checkout@v4
+      - name: cache
+        uses: actions/cache@v4
+        with:
+          path: |
+            ~/.tmp
+            .tmp
+          key: ${{ runner.os }}-connect-fastify-conformance-${{ hashFiles('Makefile') }}
+          restore-keys: |
+            ${{ runner.os }}-connect-fastify-conformance-
+      - name: testconnectfastifyconformance
+        run: make testconnectfastifyconformance
+  express:
+    runs-on: ubuntu-22.04
+    strategy:
+      matrix:
+        node-version: [16, 18, 20, 21]
+    steps:
+      - uses: actions/setup-node@v4
+        with:
+          node-version: ${{ matrix.node-version }}
+      - name: checkout
+        uses: actions/checkout@v4
+      - name: cache
+        uses: actions/cache@v4
+        with:
+          path: |
+            ~/.tmp
+            .tmp
+          key: ${{ runner.os }}-connect-express-conformance-${{ hashFiles('Makefile') }}
+          restore-keys: |
+            ${{ runner.os }}-connect-express-conformance-
+      - name: testconnectexpressconformance
+        run: make testconnectexpressconformance
   web:
     runs-on: ubuntu-22.04
     steps:

diff --git a/Makefile b/Makefile
@@ -192,14 +192,20 @@ testconnectexpresspackage: $(BUILD)/connect-express
 	npm run -w packages/connect-express jasmine
 
 .PHONY: testconformance
-testconformance: testnodeconformance testwebconformance
+testconformance: testconnectnodeconformance testconnectfastifyconformance testconnectexpressconformance testwebconformance
 
-.PHONY: testnodeconformance
-testnodeconformance: $(BUILD)/connect-node $(BUILD)/connect-fastify $(BUILD)/connect-express
+.PHONY: testconnectnodeconformance
+testconnectnodeconformance: $(BUILD)/connect-node
 	# Vanilla Node Server and Client
 	npm run -w packages/connect-node conformance
+
+.PHONY: testconnectexpressconformance
+testconnectexpressconformance: $(BUILD)/connect-express
 	# Express Server
 	npm run -w packages/connect-express conformance
+
+.PHONY: testconnectfastifyconformance
+testconnectfastifyconformance: $(BUILD)/connect-fastify
 	# Fastify Server
 	npm run -w packages/connect-fastify conformance