Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2: Remove protoc-gen-connect-es #1224

Merged
merged 1 commit into from
Sep 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

# Connect for ECMAScript

[![License](https://img.shields.io/github/license/connectrpc/connect-es?color=blue)](./LICENSE) [![Build](https://github.com/connectrpc/connect-es/actions/workflows/ci.yaml/badge.svg?branch=main)](https://github.com/connectrpc/connect-es/actions/workflows/ci.yaml) [![NPM Version](https://img.shields.io/npm/v/@connectrpc/connect/latest?color=green&label=%40connectrpc%2Fconnect)](https://www.npmjs.com/package/@connectrpc/connect) [![NPM Version](https://img.shields.io/npm/v/@connectrpc/protoc-gen-connect-es/latest?color=green&label=%40connectrpc%2Fprotoc-gen-connect-es)](https://www.npmjs.com/package/@connectrpc/protoc-gen-connect-es)
[![License](https://img.shields.io/github/license/connectrpc/connect-es?color=blue)](./LICENSE) [![Build](https://github.com/connectrpc/connect-es/actions/workflows/ci.yaml/badge.svg?branch=main)](https://github.com/connectrpc/connect-es/actions/workflows/ci.yaml) [![NPM Version](https://img.shields.io/npm/v/@connectrpc/connect/latest?color=green&label=%40connectrpc%2Fconnect)](https://www.npmjs.com/package/@connectrpc/connect)

Connect is a family of libraries for building type-safe APIs with different languages and platforms.
[@connectrpc/connect](https://www.npmjs.com/package/@connectrpc/connect) brings them to TypeScript,
Expand Down Expand Up @@ -77,8 +77,6 @@ be more than happy to chat!

- [@connectrpc/connect](https://www.npmjs.com/package/@connectrpc/connect):
RPC clients and servers for your schema ([source code](packages/connect)).
- [@connectrpc/protoc-gen-connect-es](https://www.npmjs.com/package/@connectrpc/protoc-gen-connect-es):
Code generator plugin for the services in your schema ([source code](packages/protoc-gen-connect-es)).
- [@connectrpc/connect-web](https://www.npmjs.com/package/@connectrpc/connect-web):
Adapters for web browsers, and any other platform that has the fetch API on board.
- [@connectrpc/connect-node](https://www.npmjs.com/package/@connectrpc/connect-node):
Expand Down
4 changes: 0 additions & 4 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 0 additions & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"private": true,
"workspaces": [
"packages/connect",
"packages/protoc-gen-connect-es",
"packages/connect-web",
"packages/connect-node",
"packages/connect-fastify",
Expand Down
5 changes: 1 addition & 4 deletions packages/example/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -100,10 +100,7 @@ Of course, you can use `protoc` as well if desired:
protoc -I . eliza.proto \
--plugin=protoc-gen-es=../../node_modules/.bin/protoc-gen-es \
--es_out src/gen \
--es_opt target=ts \
--plugin=protoc-gen-connect-es=../../node_modules/.bin/protoc-gen-connect-es \
--connect-es_out src/gen \
--connect-es_opt target=ts
--es_opt target=ts
```

## More examples
Expand Down
9 changes: 0 additions & 9 deletions packages/protoc-gen-connect-es/turbo.json

This file was deleted.

3 changes: 1 addition & 2 deletions scripts/release.js
Original file line number Diff line number Diff line change
Expand Up @@ -47,8 +47,7 @@ function npmPublish() {
" --workspace packages/connect-fastify" +
" --workspace packages/connect-express" +
" --workspace packages/connect-next" +
" --workspace packages/connect-migrate" +
" --workspace packages/protoc-gen-connect-es";
" --workspace packages/connect-migrate";
execSync(command, {
stdio: "inherit",
});
Expand Down