V2: Remove "credentials" option from transports #1242
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transports from
@connectrpc/connect-web
have the "credentials" option, which is passed to thefetch
call. The option passes through interceptors as well, in the "init" property of intercepted requests. The "init" property allows to change otherfetch
options in interceptors.We later added the "fetch" option to transports, which allows to override the implementation used by the transport. This option provides a more simple and homogeneous way to set options for the fetch API. For example:
We are removing the "credentials" option in v2. The "init" property of intercepted requests is also removed. As a replacement to determine whether an incoming request is a Connect GET request in server-side interceptors, the property
requestMethod: string
is added to intercepted requests. This property is symmetrical toHandlerContext.requestMethod
.