Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated protoc-gen-connect-web plugin #717

Merged
merged 2 commits into from
Jul 13, 2023

Conversation

smaye81
Copy link
Member

@smaye81 smaye81 commented Jul 13, 2023

This removes the deprecated protoc-gen-connect-web plugin from the repository. It is no longer supported and has been deprecated on npm for some time now.

If you are still depending on this package, please switch to use @bufbuild/protoc-gen-connect-es, which is the official Connect-ES plugin. The generated code is actually exactly the same, so you should not experience any issues updating

To make the switch:

npm remove @bufbuild/protoc-gen-connect-web
npm install @bufbuild/protoc-gen-connect-es

Update your buf.gen.yaml:

version: v1
plugins:
  - plugin: es
    out: src/gen
-  - plugin: connect-web
+  - plugin: connect-es
    out: src/gen

And your import paths:

- import { ElizaService } from "gen/eliza_connectweb";
+ import { ElizaService } from "gen/eliza_connect";

@smaye81 smaye81 requested a review from timostamm July 13, 2023 16:32
@smaye81 smaye81 merged commit 411bba5 into main Jul 13, 2023
@smaye81 smaye81 deleted the sayers/remove_old_plugin branch July 13, 2023 18:51
@timostamm timostamm mentioned this pull request Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants