Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle multiple set-cookie headers from fetch API Headers object #746

Merged
merged 4 commits into from
Aug 8, 2023
Merged

Conversation

tcarnes
Copy link
Contributor

@tcarnes tcarnes commented Aug 7, 2023

This is a possible solution for special handling needed to properly propagate set-cookie headers back to browser so that multiple cookies will be set. Fixes #745

@CLAassistant
Copy link

CLAassistant commented Aug 7, 2023

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@timostamm timostamm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution, Tim 🙂

@timostamm timostamm changed the title Issue #745 adding handling for set-cookie headers from fetch API Headers object Handle multiple set-cookie headers from fetch API Headers object Aug 8, 2023
@timostamm timostamm merged commit 8f48d77 into connectrpc:main Aug 8, 2023
3 of 4 checks passed
@timostamm timostamm mentioned this pull request Aug 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to set multiple cookies from within service method handler
3 participants