-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add conformance tests for connect-node #886
Conversation
53e8bee
to
083a1e0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did not take a close look at the server implementation, but this looks solid 👍
Left one comment about error detail debug values.
The readme for this new package needs more details, and the test run need to be wired up in make. I guess it only makes sense to do that after conformance v1 has been released.
The old crosstests need to be removed from this repo. I guess this is only feasible after #890 (we'll also want to run a Node fetch client, a browser fetch client, and at least retain the browserstack tests).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still looking solid to me 🙂 Would be great to have one of the conformance authors take a look, though.
Doesn't seem great to merge before conformance is released. What's your take?
Agree on conformance authors taking a look, about merging before v1 we are only merging to a branch so that I can continue to work on other environments |
Co-authored-by: Timo Stamm <ts@timostamm.de>
cd9b414
to
6e606f2
Compare
connect-node-conformance
with server implementation
@timostamm @smaye81 Added the test to CI. This is now good to go |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice to remove the dep on fflate
as noted in #886 (comment).
LGTM from me, but let's have @smaye81 take a look.
Sorry for the delay @srikrsna-buf. Left some comments. |
@@ -0,0 +1,21 @@ | |||
features: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor nits that can help clean this up:
- You can omit
protocols
andcodecs
since all options are supported (if absent, all are assumed) - You can also omit
supportsTls
,supportsConnectGet
,requiresConnectVersionHeader
, andsupportsMessageReceiveLimit
since you have them listed as the defaults and if absent, the defaults are assumed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did think of omitting the defaults but it just felt easier to parse and see what is included just by looking at the config. I'll omit them in a separate PR.
Add
connect-node-conformance
package with server implementation. Based on the reference server implementation.Tested with the following conformance config: