Skip to content

catch up #380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 8, 2025
Merged

catch up #380

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e789c89
refactor: improved error handling logic
connorabbas Aug 8, 2025
2b00cf9
refactor: better error handling
connorabbas Aug 8, 2025
54f2772
Merge branch 'master' of github.com:connorabbas/laravel-primevue-star…
connorabbas Aug 8, 2025
ca0b9e4
Merge pull request #378 from connorabbas/develop
connorabbas Aug 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions bootstrap/app.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,13 @@
];

if (in_array($statusCode, [500, 503, 404, 403])) {
if (!$request->inertia()) {
if (
$statusCode === 500
&& app()->hasDebugModeEnabled()
&& get_class($exception) !== ErrorToastException::class
) {
return $response;
} elseif (!$request->inertia()) {
// Show error page component for standard visits
return Inertia::render('Error', [
'errorTitles' => $errorTitles,
Expand All @@ -62,10 +68,6 @@
->toResponse($request)
->setStatusCode($statusCode);
} else {
// Show standard modal for easier debugging locally
if (app()->hasDebugModeEnabled() && $statusCode === 500) {
return $response;
}
// Return JSON response for PrimeVue toast to display, handled by Inertia router event listener
$errorSummary = "$statusCode - $errorTitles[$statusCode]";
$errorDetail = $errorDetails[$statusCode];
Expand Down