Add an assertion to unix_term::read_bytes
to prevent reading past the end of a buffer
#225
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The (marked safe)
read_bytes
function makes a call to the unsafe functionlibc::read
. Ifread_bytes
were to be called with acount
value larger than the length ofbuf
, the call tolibc::read
would be undefined behaviour and unsafe. All current callsites ofread_bytes
appear OK, but adding an assertion would ensure that all possible calls toread_bytes
will be safe. If you would prefer to avoid a runtime assertion, I would suggest markingread_bytes
as unsafe instead.