Fix deprecation issue with Symfony Console #1184
Closed
+16
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or addCommand method
Contributor
God catch, Symfony 6 does not have a addCommand method yet, Symfony 7 triggers the deprecation warning to use it tough. The CI backwards check is red for some other reason, the code is fine. |
Author
|
CI Fixed in #1185 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This pull request make sure users don't get a deprecated message if they are using a newer version of Symfony Console:
Summary
Added a check to see if the new
addCommandmethod exists, otherwise fallback to theaddmethodDescription
The
addmethod will be removed in symfony/console 8.0