Security module update #2312
Merged
Security module update #2312
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antares1470
requested review from
mimosa2,
Delphinus8821,
OrionsGuardian,
Quasar985 and
andromeda-224
|
andromeda-224
approved these changes
Jun 4, 2025
Delphinus8821
approved these changes
Jun 4, 2025
OrionsGuardian
approved these changes
Jun 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Reviewed the checklist
Reviewed feedback from the "Sonar Cloud" bot. Note that you have to wait
for the "CI / Unit Tests") to complete first. Failed Unit tests can be
debugged by adding the label "verbose logging" to the GitHub PR.
Description of the Change
Made some updates to Core Security. Namely added unit tests, fixed a bug, removed some unused classes, and other code cleanup
Alternate Designs
Why Should This Be In Core?
More unit tests is good. Code should be more maintainable
Benefits
More unit tests, easier maintenance
Possible Drawbacks
Verification Process
Applicable Issues