New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

return early for closed console during shutdown #85

Closed

henry118 wants to merge 1 commit into containerd:main from henry118:conclose

Member

henry118 commented Dec 17, 2024

I believe this patch is required for a proper implementation of containerd/containerd#11161.

Without this patch, double invocation of Shutdown will cause the shim to hang for the TestContainerExecLargeOutputWithTTY test case.


          return early for closed console during shutdown

d3ea05a

Signed-off-by: Henry Wang <henwang@amazon.com>

henry118 mentioned this pull request

make sure console master tty is closed on task exit containerd/containerd#11161

Merged

austinvazquez approved these changes

View reviewed changes

henry118 closed this

Member Author

henry118 commented Dec 18, 2024

nvm, this is no longer needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet