fix: catch discard error and return#204
Open
ningmingxiao wants to merge 1 commit intocontainerd:mainfrom
Open
Conversation
ningmingxiao
force-pushed
the
dev_patch
branch
2 times, most recently
from
6976588 to
be12196
Compare
Member
|
Sorry for the late reply. I've updated GitHub Actions. Can you rebase this PR against main? |
ningmingxiao
force-pushed
the
dev_patch
branch
from
be12196 to
fe96bdd
Compare
Author
|
done thanks @kzys |
Author
Member
|
Did you confirm this fixed the issue? Looking through the bufio implementation of |
ningmingxiao
force-pushed
the
dev_patch
branch
from
fe96bdd to
e3b5a07
Compare
ningmingxiao
changed the title
Author
|
you are right I create new pr will fix. @dmcgowan |
ningmingxiao
force-pushed
the
dev_patch
branch
2 times, most recently
from
2f33066 to
72984df
Compare
Member
|
Catching any error on discard makes sense and exiting. If the discard did not succeed then the connection must be ended as it is no longer in a processable state. |
ningmingxiao
force-pushed
the
dev_patch
branch
from
72984df to
c12e5ff
Compare
Author
|
done thanks @dmcgowan |
ningmingxiao
changed the title
Signed-off-by: ningmingxiao <ning.mingxiao@zte.com.cn>
ningmingxiao
force-pushed
the
dev_patch
branch
from
c12e5ff to
847da32
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to fix containerd/containerd#12669 @fuweid @dmcgowan