Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

krun: fix libkrun_unload #1668

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

eriksjolund
Copy link
Contributor

@eriksjolund eriksjolund commented Feb 12, 2025

I haven't tested the PR yet so I mark it as a draft.

@eriksjolund eriksjolund marked this pull request as draft February 12, 2025 18:12
@eriksjolund
Copy link
Contributor Author

According to the man page
https://man7.org/linux/man-pages/man3/dlclose.3p.html
a non-zero return value indicates an error occurred.
I made a new version so that now the condition is r != 0

Regarding testing the PR:
I tried adding libcrun_debug() in libkrun_unload() but I don't
know how to be able to see such output.

If I remember correctly I tested something like

podman --log-level=debug --runtime-flag debug --runtime-flag log=file:/tmp/mylog --runtime /home/test/bin/krun run --rm ...

Anyway, feel free to merge the PR if it looks okay. Or maybe you could give me some tips of how to verify that the PR works?

Signed-off-by: Erik Sjölund <erik.sjolund@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant