-
Notifications
You must be signed in to change notification settings - Fork 31
Add nri-plugins operator #208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
89f8a23 to
5460d45
Compare
|
A general comment about the PR... Although this is definitely not a showstopper/biggie, but since we're lifting existing code over from another repository, I wonder if the current PR commit history makes sense for each commit, or if it could be squashed to fewer ones. For instance, cannot we create the operator directly in the final location instead of first adding it in one location then moving it to another ? Also, it looks to me like the first two commits could as well be squashed together. If I try to take a milky-way perspective at the full set of additions in this PR, it seems to me that a more logical set of commits would be:
|
operator/config/crd/bases/topology.node.k8s.io_noderesourcetopologies.yaml
Show resolved
Hide resolved
|
First commit message has an outdated reference to |
deac93f to
caab8d2
Compare
|
@fmuyassarov Here is a rewritten history which is not squashed to a single commit and is more along the lines what I've been thinking of: https://github.com/klihub/nri-plugins/tree/devel/plugins-operator |
3d8a626 to
6fa38c8
Compare
Introduce an operator for life-cycle-management of NRI plugins. Users are expected to interact with the operator through NriPluginDeployment namespaced Custom Resource. Signed-off-by: Feruzjon Muyassarov <feruzjon.muyassarov@intel.com> Co-authored-by: Krisztian Litkey <krisztian.litkey@intel.com>
6fa38c8 to
f872ad0
Compare
kad
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have any concerns about this PR, except deletion of files under docs/deployment/. Is that expected?
We are not deleting docs but rather re-structuring them to accommodate the operator document. You can also see from the changes lines at the top of the PR. |
kad
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok. mine bad, didn't notice moving files around. LGTM
Move the operator code from:
Also, refactor the nri-plugins so that we can reuse the already existing CRD yamls instead of duplicating them.
There is one thing left to be added, which is image build refactoring. I will add it soon, but the rest is ready for review.