[stacked 4/5] metrics: add policy system collector. #405
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klihub
force-pushed
the
metrics/policy-system-collector
branch
2 times, most recently
from
f0856b2
to
bfc293d
Compare
klihub
changed the title
klihub
force-pushed
the
metrics/policy-system-collector
branch
4 times, most recently
from
90e774c
to
ac2049d
Compare
klihub
changed the title
klihub
changed the title
klihub
force-pushed
the
metrics/policy-system-collector
branch
from
ac2049d
to
0a3330d
Compare
Rework our metrics collector registry to take care most of the necessary bits fo metrics registration, collection and gathering. Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
Update cgroupstats collector for the reworked metrics registry. Split out automatic registration to a register subpackage. Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
Remove the old resmgr-triggered polling of policy metrics and the old resmgr-level polling policy metrics collector. Implement policy metrics collection in the policy package itself. Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
Remove the old opencensus-based prometheus exporter. Rework prometheus exporting using our update metrics registry and a promhttp /metrics-handler. Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
Add configuration bits for controlling which metrics are collected. Enable collection of policy metrics by default. Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
Remove obsolete and unused option entries. Give a warning about using the now-obsolete '-metrics-interval' argument. It's used unconditionally by our existing Helm charts, so we'll phase it out a bit more gently. Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
Add a metrics/collectors subpackage. When imported it pulls in and registers the fairly standard buildinfo, process and golang runtime collectors. Turn on the build info collector by default. Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
Simplify the policy-backend metrics collection interface, reducing it to a single GetMetrics() call and a returned Metrics interface which simply implements the collector- like Describe() and Collect() interfaces. Update policy implementations accordingly. Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
Implement collection of policy 'system' prometheus metrics. We collect per each memory node - memory capcity - memory usage - number of containers sharing the node We collect per each CPU core - allocation from that core - number of containers sharing the core Signed-off-by: Krisztian Litkey <krisztian.litkey@intel.com>
klihub
force-pushed
the
metrics/policy-system-collector
branch
from
0a3330d
to
02aa6d1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notes: This PR is stacked on top of #408.
Implement collection of policy 'system' prometheus metrics.
For each memory node collect
- memory capcity
- memory usage
- number of containers sharing the node
For each CPU core collect
- total container allocations from that core
- number of containers sharing the core