Feat pull images before teardown containers on up command #1298
+278
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lisongmin
force-pushed
the
feat-pull-before-teardown
branch
from
86de1ab to
276a781
Compare
p12tic
approved these changes
Sep 5, 2025
Signed-off-by: Songmin Li <lisongmin@protonmail.com>
When both image and build section exist, and the image starts with "localhost/", podman-compose tries to pull the image, which is not expected. Signed-off-by: Songmin Li <lisongmin@protonmail.com>
|
Seems good. Why this is not yet merged? |
p12tic
reviewed
Nov 1, 2025
| log.error("Build command failed") | ||
| if not args.dry_run: | ||
| return build_exit_code | ||
| return build_exit_code |
There was a problem hiding this comment.
Rather large commit just to fix pylint warnings
There was a problem hiding this comment.
I got the following warning from pylint:
podman_compose.py:3215:12: W1203: Use lazy % formatting in logging functions (logging-fstring-interpolation)
podman_compose.py:3220:12: W1203: Use lazy % formatting in logging functions (logging-fstring-interpolation)
podman_compose.py:3283:0: R0911: Too many return statements (7/6) (too-many-return-statements)
And since build image and pull image are both prepare images before running, I split it out to the prepare_images.
Any idea to fix the warning with less changes?
There was a problem hiding this comment.
Hi, p12tic,
I just split the last commit into two commits, but i don't know if this is what you want.
Please check it.
Signed-off-by: Songmin Li <lisongmin@protonmail.com>
Signed-off-by: Songmin Li <lisongmin@protonmail.com>
lisongmin
force-pushed
the
feat-pull-before-teardown
branch
from
276a781 to
3a42866
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reduces services downtime by pulling images before teardown containers on up command.