Skip to content

feat(build): add support for 'cache_from' and 'cache_to' instructions #744

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

NefixEstrada
Copy link

Signed-off-by: Néfix Estrada <nefixestrada@gmail.com>
Copy link
Collaborator

@p12tic p12tic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but needs unit tests.

@NefixEstrada
Copy link
Author

Looks good, but needs unit tests.

I've been using it in production for a while now. Could you please point me how to write them?

Thank you,

Néfix Estrada

@p12tic
Copy link
Collaborator

p12tic commented Jan 5, 2025

Apologies for late response. Unit tests needed additional refactoring of the code which was only recently done. cache_from and cache_to feature has been merged via #1092, so this PR is no longer needed.

@p12tic p12tic closed this Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants