chore: update README #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lstocchi <lstocchi@redhat.com>
benoitf
approved these changes
May 2, 2024
README.md
Outdated
| cd podman-desktop-extension-minikube | ||
| yarn install | ||
| yarn build |
There was a problem hiding this comment.
I'm wondering if we should not have yarn watch on this first terminal
as we're developing this extension, probably it should be in watch mode ?
There was a problem hiding this comment.
I did review but forgot the submit button....
There was a problem hiding this comment.
Something like ?
If you are live editing the extension, from podman-desktop-extension-minikube folder, just use:
yarn watch
There was a problem hiding this comment.
Or you prefer having yarn watch above?
There was a problem hiding this comment.
for contributing I would expect to have watch mode for the extension b/c else I may think it won't work, that my changes are not being used, etc.
lstocchi
commented
May 2, 2024
Signed-off-by: Luca Stocchi <49404737+lstocchi@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.