chore(ci): adding concurrency option to pr-check #8997
Conversation
Signed-off-by: axel7083 <42176370+axel7083@users.noreply.github.com>
axel7083
requested review from
cdrage,
deboer-tim and
lstocchi
and removed request for
a team
| @@ -411,7 +415,7 @@ jobs: | |||
| always() | |||
| steps: | |||
| - name: Evaluate the Windows Update test results | |||
| run: | | |||
| run: | | |||
| echo "Windows updater result: ${{ needs.run-update-e2e-test.result }}" | |||
| if [ "${{ needs.run-update-e2e-test.result }}" = "failure" ]; then | |||
| echo "Windows udpater test failed..." | |||
There was a problem hiding this comment.
the linter did the changes
| pull_request: | ||
| types: [labeled, synchronize, opened, reopened] | ||
|
|
||
| concurrency: | ||
| group: ${{ github.workflow }}-${{ github.ref }} |
There was a problem hiding this comment.
looks like sometimes the pattern is
${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
There was a problem hiding this comment.
Where did you find this ? Because I was reading opencv/ci-gha-workflow#78 and it does not seems to work.
The github documentation recommend ${{ github.workflow }}-${{ github.ref }}
There was a problem hiding this comment.
For example, you can use the concurrency keyword immediately after where trigger conditions are defined to limit the concurrency of entire workflow runs for a specific branch ref https://docs.github.com/en/actions/writing-workflows/workflow-syntax-for-github-actions#example-using-concurrency-and-the-default-behavior
There was a problem hiding this comment.
There was a problem hiding this comment.
What would be the difference compare to the value given in the github documentation ?
There was a problem hiding this comment.
you can change the branch of the PR I guess ?
What does this PR do?
Adding the
concurrencyoption to pr-check, making Github cancel previous github actions for a given branch if new one are started (E.g. new commits, rebase etc.)Screenshot / video of UI
N/A
What issues does this PR fix or reference?
Fixes #8811
How to test this PR?