-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] feat: add cdi-spec-dir option to top level options #21448
base: main
Are you sure you want to change the base?
Conversation
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: micahcc The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
7f8f843
to
957bd6d
Compare
Needs: containers/common#1834 |
A friendly reminder that this PR had no activity for 30 days. |
957bd6d
to
4149dc6
Compare
Signed-off-by: Micah Chambers (eos) <mchambers@anduril.com>
Signed-off-by: Micah Chambers (eos) <mchambers@anduril.com>
Ephemeral COPR build failed. @containers/packit-build please check. |
Is there any intention of merging this PR? I did try to use the As best as I understand, this PR is what would make it do that something. |
@micahcc are you able to move this forward now? |
In response to #18292.
One of the primary benefits of podman is that its possible run without altering the host system. By allowing cdi directories to be passed via command line it maintains this feature.
I'm particularly interested in running podman in a nix-shell with nvidia GPU passthough. Podman and all its dependencies (including nvidia-container-toolkit) come from nix and the host system again doesn't need altering. The one problem with that right now is that I have to write /etc/cdi/nvidia.yaml to be able to use the GPU. Note that the old nvidia-runtime-hook does not work for my use case (which involves vulkan passthrough).
With this change it will be possible to generate a user nvidia.yaml and point podman at that user-specific mount instructions there.
Does this PR introduce a user-facing change?