Skip to content

Conversation

@evidolob
Copy link
Contributor

This is draft PR to check that changed introduced in libhvee in containers/libhvee#258 are fully functional and doesn't break anything in podman.

Checklist

Ensure you have completed the following checklist for your pull request to be reviewed:

  • Certify you wrote the patch or otherwise have the right to pass it on as an open-source patch by signing all
    commits. (git commit -s). (If needed, use git commit -s --amend). The author email must match
    the sign-off email address. See CONTRIBUTING.md
    for more information.
  • Referenced issues using Fixes: #00000 in commit message (if applicable)
  • Tests have been added/updated (or no tests are needed)
  • Documentation has been updated (or no documentation changes are needed)
  • All commits pass make validatepr (format/lint checks)
  • Release note entered in the section below (or None if no user-facing changes)

Does this PR introduce a user-facing change?

None

@Honny1
Copy link
Member

Honny1 commented Dec 23, 2025

cc @l0rd @baude

@l0rd
Copy link
Member

l0rd commented Dec 24, 2025

The linter is complaining. @evidolob I would suggest the follwing things to get this working:

  1. do the vendoring from a clean branch using the commands
go mod edit -replace github.com/containers/libhvee=github.com/evidolob/libhvee@rework_to_ps
go mod tidy
go mod vendor
  1. locally build, run the linter and run unit and e2e tests (some documentation is here and here)
.\winmake podman
.\winmake lint
.\winmake localunit
.\winamke localmachine

Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
Signed-off-by: Yevhen Vydolob <yvydolob@redhat.com>
@baude baude added the No New Tests Allow PR to proceed without adding regression tests label Jan 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

machine No New Tests Allow PR to proceed without adding regression tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants