Skip to content

Commit ae29e55

Browse files
authored
Merge pull request #658 from contember/fix/listener-return-type
fix binding listener return type
2 parents 0cbcf50 + cddd184 commit ae29e55

File tree

3 files changed

+6
-5
lines changed

3 files changed

+6
-5
lines changed

build/api/binding.api.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -207,7 +207,7 @@ export namespace EntityAccessor {
207207
// (undocumented)
208208
export type BatchUpdatesHandler = (getAccessor: GetEntityAccessor, options: BatchUpdatesOptions) => void;
209209
// (undocumented)
210-
export type BeforePersistHandler = (getAccessor: GetEntityAccessor, options: AsyncBatchUpdatesOptions) => void | Promise<void | BeforePersistHandler>;
210+
export type BeforePersistHandler = (getAccessor: GetEntityAccessor, options: AsyncBatchUpdatesOptions) => void | BeforePersistHandler | Promise<void | BeforePersistHandler>;
211211
// (undocumented)
212212
export interface EntityEventListenerMap extends RuntimeEntityEventListenerMap {
213213
// (undocumented)
@@ -233,7 +233,7 @@ export namespace EntityAccessor {
233233
// (undocumented)
234234
export type PersistErrorHandler = (getAccessor: GetEntityAccessor, options: PersistErrorOptions) => void | Promise<void>;
235235
// (undocumented)
236-
export type PersistSuccessHandler = (getAccessor: GetEntityAccessor, options: PersistSuccessOptions) => void | Promise<void | PersistSuccessHandler>;
236+
export type PersistSuccessHandler = (getAccessor: GetEntityAccessor, options: PersistSuccessOptions) => void | PersistSuccessHandler | Promise<void | PersistSuccessHandler>;
237237
// (undocumented)
238238
export interface RuntimeEntityEventListenerMap {
239239
// (undocumented)

packages/binding/src/accessors/EntityAccessor.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -262,7 +262,7 @@ namespace EntityAccessor {
262262
export type BeforePersistHandler = (
263263
getAccessor: GetEntityAccessor,
264264
options: AsyncBatchUpdatesOptions,
265-
) => void | Promise<void | BeforePersistHandler>
265+
) => void | BeforePersistHandler | Promise<void | BeforePersistHandler>
266266

267267
export type PersistErrorHandler = (
268268
getAccessor: GetEntityAccessor,
@@ -272,7 +272,7 @@ namespace EntityAccessor {
272272
export type PersistSuccessHandler = (
273273
getAccessor: GetEntityAccessor,
274274
options: PersistSuccessOptions,
275-
) => void | Promise<void | PersistSuccessHandler>
275+
) => void | PersistSuccessHandler | Promise<void | PersistSuccessHandler>
276276

277277
export interface RuntimeEntityEventListenerMap {
278278
beforePersist: BeforePersistHandler

packages/binding/src/treeParameters/EventListenersStore.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
1+
type AnyFunction = (...args: any[]) => any
12
type GenericEventsMap<EventTypes extends string> = {
2-
[K in EventTypes]?: (...args: any[]) => void | Promise<void | any>
3+
[K in EventTypes]?: (...args: any[]) => void | AnyFunction | Promise<void | AnyFunction>
34
}
45

56
export class EventListenersStore<EventTypes extends string, Events extends GenericEventsMap<EventTypes>> {

0 commit comments

Comments
 (0)