fix(binding): fix type in persist handler - it may return next handle…

…r without promise
contember · Dec 27, 2023 · cddd184 · cddd184
1 parent 0cbcf50
commit cddd184
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 5 deletions.
diff --git a/build/api/binding.api.md b/build/api/binding.api.md
@@ -207,7 +207,7 @@ export namespace EntityAccessor {
     // (undocumented)
     export type BatchUpdatesHandler = (getAccessor: GetEntityAccessor, options: BatchUpdatesOptions) => void;
     // (undocumented)
-    export type BeforePersistHandler = (getAccessor: GetEntityAccessor, options: AsyncBatchUpdatesOptions) => void | Promise<void | BeforePersistHandler>;
+    export type BeforePersistHandler = (getAccessor: GetEntityAccessor, options: AsyncBatchUpdatesOptions) => void | BeforePersistHandler | Promise<void | BeforePersistHandler>;
     // (undocumented)
     export interface EntityEventListenerMap extends RuntimeEntityEventListenerMap {
         // (undocumented)
@@ -233,7 +233,7 @@ export namespace EntityAccessor {
     // (undocumented)
     export type PersistErrorHandler = (getAccessor: GetEntityAccessor, options: PersistErrorOptions) => void | Promise<void>;
     // (undocumented)
-    export type PersistSuccessHandler = (getAccessor: GetEntityAccessor, options: PersistSuccessOptions) => void | Promise<void | PersistSuccessHandler>;
+    export type PersistSuccessHandler = (getAccessor: GetEntityAccessor, options: PersistSuccessOptions) => void | PersistSuccessHandler | Promise<void | PersistSuccessHandler>;
     // (undocumented)
     export interface RuntimeEntityEventListenerMap {
         // (undocumented)

diff --git a/packages/binding/src/accessors/EntityAccessor.ts b/packages/binding/src/accessors/EntityAccessor.ts
@@ -262,7 +262,7 @@ namespace EntityAccessor {
 	export type BeforePersistHandler = (
 		getAccessor: GetEntityAccessor,
 		options: AsyncBatchUpdatesOptions,
-	) => void | Promise<void | BeforePersistHandler>
+	) => void | BeforePersistHandler | Promise<void | BeforePersistHandler>
 
 	export type PersistErrorHandler = (
 		getAccessor: GetEntityAccessor,
@@ -272,7 +272,7 @@ namespace EntityAccessor {
 	export type PersistSuccessHandler = (
 		getAccessor: GetEntityAccessor,
 		options: PersistSuccessOptions,
-	) => void | Promise<void | PersistSuccessHandler>
+	) => void | PersistSuccessHandler | Promise<void | PersistSuccessHandler>
 
 	export interface RuntimeEntityEventListenerMap {
 		beforePersist: BeforePersistHandler

diff --git a/packages/binding/src/treeParameters/EventListenersStore.ts b/packages/binding/src/treeParameters/EventListenersStore.ts
@@ -1,5 +1,6 @@
+type AnyFunction = (...args: any[]) => any
 type GenericEventsMap<EventTypes extends string> = {
-	[K in EventTypes]?: (...args: any[]) => void | Promise<void | any>
+	[K in EventTypes]?: (...args: any[]) => void | AnyFunction | Promise<void | AnyFunction>
 }
 
 export class EventListenersStore<EventTypes extends string, Events extends GenericEventsMap<EventTypes>> {