Added where LINQ clause to filter out empty strings from originConfigs. #14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there,
I set out to use this CORS module for the Content Manager Service API but found that there was a problem with it.
In the readme it states that:
However, the if statement that allows this logic did not work because there was always at least one string in the origins array (an empty one, if 'allowedOrigins' is not set).
Therefore, I've added a Where LINQ clause that ensures that no empty strings end up in this array, meaning that the if statement is hit and it does apply the default behaviour of allowing all origins.
I have tested this all with Content manager 9.3. CORS requests from any domain are now able to succeed when 'allowedOrigins' is not set or has an empty value, and specific domains can still be allowed as well if that is what is required.