Conversation
swadeley
force-pushed
the
swadeley/add_centirepos
branch
from
9d8c1ca to
18ee569
Compare
| .toString() | ||
| .padStart(2, '0'); | ||
|
|
||
| export const randomUrl = () => `https://stephenw.fedorapeople.org/centirepos/repo${randomNum()}/`; |
Member
There was a problem hiding this comment.
this is nice, much simpler this way 👍🏼
but it would be even better to have those repos in our fixtures repo, which was created for this exact purpose, i.e.: hosting our's testing repositories, where the ownership would be on the entire team 😄
Member
Author
There was a problem hiding this comment.
Hi, I think this might work:
Member
There was a problem hiding this comment.
that would, awesome! 👏🏼
just the URL needs to be changed now to point to the new location 😄
Member
Author
There was a problem hiding this comment.
@dominikvagner rebased and updated to use github repo path.
Thank you.
Member
Author
There was a problem hiding this comment.
Changes to repo path also applied in:
swadeley
force-pushed
the
swadeley/add_centirepos
branch
from
18ee569 to
a3cab8b
Compare
no number in URL
swadeley
force-pushed
the
swadeley/add_centirepos
branch
from
a3cab8b to
b35eab6
Compare
swadeley
force-pushed
the
swadeley/add_centirepos
branch
from
8fc93f3 to
9a2a4e8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
I made a new batch of 100 repos without a number in the URL
The multirepos path with a rank number in URL causes problems when that number corresponds to a release version.
Testing steps
Tests pass