Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: updates to allow usage of newer cda client [] #1588

Merged
merged 3 commits into from
Nov 20, 2023
Merged

chore: updates to allow usage of newer cda client [] #1588

merged 3 commits into from
Nov 20, 2023
+77 −137

Conversation

jjolton-contentful
Copy link
Contributor

@jjolton-contentful jjolton-contentful commented Nov 14, 2023 •
edited
Loading

These tweaks allow us to upgrade contentful.js

I came to these conclusions via these error messages:

[Error: ValidationError: Invalid "resolveLinks" provided, The use of the 'resolveLinks' parameter is no longer supported. By default, links are resolved. If you do not want to resolve links, use client.withoutLinkResolution.]

[Error: ValidationError: Invalid "locale" provided, The use of locale='*' is no longer supported.To fetch an entry in all existing locales, use client.withAllLocales instead of the locale='*' parameter.]

@jjolton-contentful jjolton-contentful requested a review from a team as a code owner November 14, 2023 22:00
@jjolton-contentful jjolton-contentful marked this pull request as draft November 14, 2023 22:00
@jjolton-contentful jjolton-contentful marked this pull request as ready for review November 14, 2023 22:16
@jjolton-contentful jjolton-contentful changed the title chore: newer cda client uses a different way of disabling link resolution [] chore: updates to allow usage of newer cda client [] Nov 14, 2023
@jjolton-contentful jjolton-contentful mentioned this pull request Nov 14, 2023
Closed
mgoudy91
mgoudy91 reviewed Nov 14, 2023
View reviewed changes
Copy link
Contributor

@mgoudy91 mgoudy91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me, but let's make sure the phoenixes feel cool about it too

dependabot bot and others added 3 commits November 20, 2023 08:40
@dependabot @jjolton-contentful
build(deps): bump contentful from 9.3.5 to 10.6.9
f7b543c 
Bumps [contentful](https://github.com/contentful/contentful.js) from 9.3.5 to 10.6.9.
- [Release notes](https://github.com/contentful/contentful.js/releases)
- [Commits](contentful/contentful.js@v9.3.5...v10.6.9)

---
updated-dependencies:
- dependency-name: contentful
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@jjolton-contentful
chore: newer cda client uses a different way of disabling link resolu…
dc76371 
…tion []
@jjolton-contentful
chore: newer cda client uses a different way of requesting all locale…
bf4f9bc 
…s []
@jjolton-contentful jjolton-contentful force-pushed the jared/update-cda-client-resolve-links-option branch from bfa3276 to bf4f9bc Compare November 20, 2023 15:40
@jjolton-contentful jjolton-contentful requested a review from a team as a code owner November 20, 2023 15:40
mgoudy91
mgoudy91 approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@mgoudy91 mgoudy91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me, but let's make sure the phoenixes feel cool about it too

given this team doesn't really exist anymore I think you're good to merge actually ha

@jjolton-contentful jjolton-contentful merged commit d440705 into master Nov 20, 2023
2 checks passed
@jjolton-contentful jjolton-contentful deleted the jared/update-cda-client-resolve-links-option branch November 20, 2023 17:10
@contentful-automation
Copy link

🎉 This PR is included in version 7.19.95 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mgoudy91 mgoudy91 mgoudy91 approved these changes

@ghepting ghepting Awaiting requested review from ghepting

@t-col t-col Awaiting requested review from t-col

@david-shibley-contentful david-shibley-contentful Awaiting requested review from david-shibley-contentful

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jjolton-contentful @mgoudy91