feat!: move DND to the host application and ensure WYSIWYG experience [SPA-2744]#1216
Merged
Thomas Kellermeier (Chaoste) merged 20 commits intodevelopmentfrom Aug 6, 2025
Merged
feat!: move DND to the host application and ensure WYSIWYG experience [SPA-2744]#1216Thomas Kellermeier (Chaoste) merged 20 commits intodevelopmentfrom
Thomas Kellermeier (Chaoste) merged 20 commits intodevelopmentfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thomas Kellermeier (Chaoste)
force-pushed
the
v3-prerelease
branch
from
d0f2745 to
fbf417a
Compare
Maxim Cheremisin (maxcheremisin)
force-pushed
the
v3-prerelease
branch
from
8e92991 to
bcbfd82
Compare
* feat: introduce SDK capability dndMigration [SPA-2745] (#1134) * feat: introduce SDK capability nativeDnd * feat: rename flag to dndMigration * feat: remove all code related to DND or any other canvas interaction * feat: merge EditorBlock and useComponent * feat: remove remaining DND code and make components render * feat: remove to be deprecated messages * fix: className render props order
* feat: add geometry update message * feat: send canvasGeometry update at every possible DOM change * style: split functions, simplify code, drop manual sourceEvent * fix: to be safe fire trailing debounce message as well * style: rename manuallyFireCanvasGeometryUpdate to sendCanvasGeometryUpdate * fix: dont update manually but ensure observer stays active * style: split resize and mutations into two separate effects * fix: send message argument type * fix: use message argument type
Maxim Cheremisin (maxcheremisin)
force-pushed
the
v3-prerelease
branch
from
68b7839 to
fe8fd0b
Compare
fix: increase handshake timeout for v3 switch [SPA-3058]
Thomas Kellermeier (Chaoste)
requested review from
Anwar Ahmad (anwaar931) and
Marc Müller (marcmll)
and removed request for
a team
Thomas Kellermeier (Chaoste)
requested a review
from Maxim Cheremisin (maxcheremisin)
Maxim Cheremisin (maxcheremisin)
approved these changes
Aug 6, 2025
Member
Maxim Cheremisin (maxcheremisin)
left a comment
Maxim Cheremisin (maxcheremisin)
left a comment
There was a problem hiding this comment.
LET'S GO 🚀
Merged
Thomas Kellermeier (Chaoste)
changed the title
Thomas Kellermeier (Chaoste)
changed the title
Thomas Kellermeier (Chaoste)
added a commit
that referenced
this pull request
Aug 6, 2025
…SPA-2744] (#1216) * feat: introduce SDK capability dndMigration [SPA-2745] (#1134) * feat: introduce SDK capability nativeDnd * feat: rename flag to dndMigration * chore: allow v3-prerelease branch for lerna publishing * feat!: remove dnd [SPA-2803] (#1138) * feat: introduce SDK capability dndMigration [SPA-2745] (#1134) * feat: introduce SDK capability nativeDnd * feat: rename flag to dndMigration * feat: remove all code related to DND or any other canvas interaction * feat: merge EditorBlock and useComponent * feat: remove remaining DND code and make components render * feat: remove to be deprecated messages * fix: className render props order * feat(visual-editor): Send CanvasGeometryUpdated Event [SPA-2804] (#1144) * feat: add geometry update message * feat: send canvasGeometry update at every possible DOM change * style: split functions, simplify code, drop manual sourceEvent * fix: to be safe fire trailing debounce message as well * style: rename manuallyFireCanvasGeometryUpdate to sendCanvasGeometryUpdate * fix: dont update manually but ensure observer stays active * style: split resize and mutations into two separate effects * fix: send message argument type * fix: use message argument type * feat: use offsetHeight for canvasGeometry [] (#1149) * feat: listen to the entire html for canvas geometry [SPA-2804] (#1155) * feat: [] skip hidden nodes (#1193) * fix: remove old PreviewUnboundImage and unnnecessary special casing (#1171) * fix: remove falsly kept file from merge conflict * fix: render empty carousel and containers with min width and height * fix: correctly render editor attribets on CustomImage * test: check created CSS code for merged pattern default * fix: adjust test due to removed border-box rule on every node * chore: remove v3 downstream CI updates as it didnt work anyways * chore: [] send initial canvas geometry (#1219) * fix: render cfVisibility in editor mode for CSR apps * fix: mocks in tests * fix: increase handshake timeout * chore: remove special casing from lerna and CI config for v3 branch --------- Co-authored-by: Maxim Cheremisin <maxcheremisin2008@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Releasing Version 3.0.0
To ensure parity between editor and preview mode (
VisualEditorRootandPreviewDeliveryRoot), both now use a similar rendering flow. Also, the editor mode doesn't include a DND library for the editing experience as that moved to the host application. Components will render similar in both modes by dropping the wrapping element that was required for the DND library.Upgrading to this major version doens't introduce any breaking changes in the endusers code.