fix(entity-store): split into asset and entry map to prevent id collision #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrishelgert
force-pushed
the
fix/entity-store
branch
from
a7bc176 to
b099852
Compare
chrishelgert
force-pushed
the
fix/entity-store
branch
from
b099852 to
cd2f1de
Compare
aodhagan-cf
reviewed
Nov 16, 2023
| const store = new EntityStore({ entities: [patchedAsset, patchedEntry], locale }); | ||
|
|
||
| const [resolvedAsset, resolvedEntry] = await Promise.all([ | ||
| store.fetchAsset('1'), |
There was a problem hiding this comment.
What happens with?
public get entities() {
return [...this.entryMap.values(), ...this.assetMap.values()];
}
There was a problem hiding this comment.
() is it possible to have duplicates? EntityStore
There was a problem hiding this comment.
yes there it is possible to have duplicate sys.id, but you also have the sys.type to differentiate between them, so that should be fine :)
2wce
approved these changes
Nov 17, 2023
aodhagan-cf
approved these changes
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Entry and Asset can have the same ID, therefore we should split up the entities into two maps (one for asset, one for entry)