fix: improve image URL parsing robustness across providers

[dcs-soni]

Description

Handle malformed data URLs in Bedrock, Anthropic, Gemini, and Ollama adapters. Currently, they use unsafe array destructuring when parsing data URLs, causing runtime crashes on malformed input or unexpected results even if the parsed data is not correct base64.

Data URLs can be malformed due to various reasons, like, copy/paste from applications generating invalid URLs, user provided code containing malformed base64 URLs or maybe a network connection during image uploads.

This fix:

• Prevents runtime crashes on malformed image data.
• Improves error handling and user experience.
• Improved response from the providers if the image URLs are malformed.

AI Code Review

• Team members only: AI review runs automatically when PR is opened or marked ready for review
• Team members can also trigger a review by commenting @continue-review

Checklist

• I've read the contributing guide
• [] The relevant docs, if any, have been updated or created
• [] The relevant tests, if any, have been updated or created

Screen recording or screenshot

[ When applicable, please include a short screen recording or screenshot - this makes it much easier for us as contributors to review and understand your changes. See this PR as a good example. ]

Tests

[ What tests were added or updated to ensure the changes work as expected? ]

---

Summary by cubic

Improved image data URL parsing across providers to prevent crashes on malformed inputs. Centralizes parsing logic and adds safer base64 extraction and MIME type handling.

• Bug Fixes
  • Replaced unsafe split logic with parseDataUrl and extractBase64FromDataUrl helpers.
  • Updated Anthropic, Bedrock, Gemini, Ollama, and their OpenAI adapters to handle invalid/missing image data gracefully.
  • Return clear errors instead of crashing when data URLs are malformed.

^{Written for commit 64f3e12. Summary will update automatically on new commits.}

[cubic-dev-ai]

1 issue found across 7 files

Prompt for AI agents (all 1 issues)

Understand the root cause of the following 1 issues and fix them.


<file name="core/llm/llms/Ollama.ts">

<violation number="1" location="core/llm/llms/Ollama.ts:308">
Calling extractBase64FromDataUrl here will throw on malformed data URLs and bubble up, regressing the previous behavior that tolerated bad input; wrap this in error handling or preserve the non-throwing fallback so malformed URLs don’t crash message conversion.</violation>
</file>

_{React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.}

[cubic-dev-ai]

Calling extractBase64FromDataUrl here will throw on malformed data URLs and bubble up, regressing the previous behavior that tolerated bad input; wrap this in error handling or preserve the non-throwing fallback so malformed URLs don’t crash message conversion.

Prompt for AI agents

Address the following comment on core/llm/llms/Ollama.ts at line 308:

<comment>Calling extractBase64FromDataUrl here will throw on malformed data URLs and bubble up, regressing the previous behavior that tolerated bad input; wrap this in error handling or preserve the non-throwing fallback so malformed URLs don’t crash message conversion.</comment>

<file context>
@@ -303,7 +304,9 @@ class Ollama extends BaseLLM implements ModelInstaller {
         if (part.type === &quot;imageUrl&quot; &amp;&amp; part.imageUrl) {
-          const image = part.imageUrl?.url.split(&quot;,&quot;).at(-1);
+          const image = part.imageUrl?.url
+            ? extractBase64FromDataUrl(part.imageUrl.url)
+            : undefined;
           if (image) {
</file context>

[dcs-soni]

The extractBase64FromDataUrl function now returns undefined instead of throwing on malformed URLs

[cubic-dev-ai]

Thanks for the feedback! I've saved this as a new learning to improve future reviews.

[RomneyDa]

@dcs-soni looks like some tests are failing and see cubic feedback!