Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce boxed types for margins and handling of input #1491

Merged
merged 1 commit into from
Mar 27, 2024

Introduce boxed types for margins and handling of input

e0ad300
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Introduce boxed types for margins and handling of input #1491

Introduce boxed types for margins and handling of input
e0ad300
Select commit
Loading
Failed to load commit list.
GitHub Actions / clang-tidy-review completed Mar 27, 2024 in 0s

clang-tidy-review

There were 6 warnings

Details

src/vtbackend/Terminal_test.cpp:402: warning: avoid do-while loops [cppcoreguidelines-avoid-do-while]
src/vtbackend/ViInputHandler.cpp:426: warning: parameter name 'ch' is too short, expected at least 3 characters [readability-identifier-length]
src/vtbackend/ViInputHandler.cpp:473: warning: parameter name 'ch' is too short, expected at least 3 characters [readability-identifier-length]
src/vtbackend/ViInputHandler.h:191: warning: parameter name 'ch' is too short, expected at least 3 characters [readability-identifier-length]
src/vtbackend/ViInputHandler.h:239: warning: parameter name 'ch' is too short, expected at least 3 characters [readability-identifier-length]
src/vtbackend/ViInputHandler.h:240: warning: parameter name 'ch' is too short, expected at least 3 characters [readability-identifier-length]

Annotations

Check warning on line 402 in src/vtbackend/Terminal_test.cpp

See this annotation in the file changed.

@github-actions github-actions / clang-tidy-review

clang-tidy

warning: avoid do-while loops [cppcoreguidelines-avoid-do-while]
```cpp
    REQUIRE(appHandledMouse == Handled { false });
    ^
```
<details>
<summary>Additional context</summary>

**_deps/sources/Catch2-3.4.0/src/catch2/catch_test_macros.hpp:124:** expanded from macro 'REQUIRE'
```cpp
  #define REQUIRE( ... ) INTERNAL_CATCH_TEST( "REQUIRE", Catch::ResultDisposition::Normal, __VA_ARGS__  )
                         ^
```
**_deps/sources/Catch2-3.4.0/src/catch2/internal/catch_test_macro_impl.hpp:44:** expanded from macro 'INTERNAL_CATCH_TEST'
```cpp
    do { /* NOLINT(bugprone-infinite-loop) */ \
    ^
```

</details>

Check warning on line 426 in src/vtbackend/ViInputHandler.cpp

See this annotation in the file changed.

@github-actions github-actions / clang-tidy-review

clang-tidy

warning: parameter name 'ch' is too short, expected at least 3 characters [readability-identifier-length]
```cpp
Handled ViInputHandler::handleSearchEditor(char32_t ch, Modifiers modifiers)
                                                    ^
```

Check warning on line 473 in src/vtbackend/ViInputHandler.cpp

See this annotation in the file changed.

@github-actions github-actions / clang-tidy-review

clang-tidy

warning: parameter name 'ch' is too short, expected at least 3 characters [readability-identifier-length]
```cpp
Handled ViInputHandler::sendCharPressEvent(char32_t ch, Modifiers modifiers)
                                                    ^
```

Check warning on line 191 in src/vtbackend/ViInputHandler.h

See this annotation in the file changed.

@github-actions github-actions / clang-tidy-review

clang-tidy

warning: parameter name 'ch' is too short, expected at least 3 characters [readability-identifier-length]
```cpp
    Handled sendCharPressEvent(char32_t ch, Modifiers modifiers) override;
                                        ^
```

Check warning on line 239 in src/vtbackend/ViInputHandler.h

See this annotation in the file changed.

@github-actions github-actions / clang-tidy-review

clang-tidy

warning: parameter name 'ch' is too short, expected at least 3 characters [readability-identifier-length]
```cpp
    Handled handleSearchEditor(char32_t ch, Modifiers modifiers);
                                        ^
```

Check warning on line 240 in src/vtbackend/ViInputHandler.h

See this annotation in the file changed.

@github-actions github-actions / clang-tidy-review

clang-tidy

warning: parameter name 'ch' is too short, expected at least 3 characters [readability-identifier-length]
```cpp
    Handled handleModeSwitches(char32_t ch, Modifiers modifiers);
                                        ^
```