Skip to content

Rename GetName<>() to NameOf<> and add test for TypeNameOf<> #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 8, 2025
Merged

Rename GetName<>() to NameOf<> and add test for TypeNameOf<> #22

merged 1 commit into from
Feb 8, 2025

Conversation

@christianparpart
Copy link
Member

@christianparpart christianparpart commented Feb 8, 2025 •
edited
Loading

  • be a little bit more consistent
  • prefer constexpr templated variables over function calls to also suggest the reader/user that this is not actually a runtime call, but a compile time information

@christianparpart
Rename GetName<>() to NameOf<> and add test for TypeNameOf<>
58a23f6 
Signed-off-by: Christian Parpart <christian@parpart.family>
@christianparpart christianparpart self-assigned this Feb 8, 2025
Yaraslaut
Yaraslaut approved these changes Feb 8, 2025
View reviewed changes
Copy link
Member

@Yaraslaut Yaraslaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks

@Yaraslaut Yaraslaut merged commit 6a2567b into master Feb 8, 2025
5 checks passed
@christianparpart christianparpart deleted the feature/NameOf-TypeNameOf branch February 8, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Yaraslaut Yaraslaut Yaraslaut approved these changes

Assignees

@christianparpart christianparpart

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@christianparpart @Yaraslaut