Skip to content

Commit

Permalink
Fixing missing quotes in CSS attribute selectors. When data attribute…
Browse files Browse the repository at this point in the history
… has a value eg. with `.`, the jQuery sizzle engine throws an error when there are no qutes around the value. (#1044)
  • Loading branch information
zipper committed Feb 7, 2023
1 parent 1b0ff6a commit 4613b83
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions assets/datagrid.js
Original file line number Diff line number Diff line change
Expand Up @@ -775,7 +775,7 @@ dataGridRegisterExtension('datagrid.after_inline_edit', {
var grid = $('.datagrid-' + payload._datagrid_name);

if (payload._datagrid_inline_edited) {
grid.find('tr[data-id=' + payload._datagrid_inline_edited + '] > td').addClass('edited');
grid.find('tr[data-id="' + payload._datagrid_inline_edited + '"] > td').addClass('edited');
return grid.find('.datagrid-inline-edit-trigger').removeClass('hidden');
} else if (payload._datagrid_inline_edit_cancel) {
return grid.find('.datagrid-inline-edit-trigger').removeClass('hidden');
Expand Down Expand Up @@ -884,7 +884,7 @@ dataGridRegisterExtension('datagrid.redraw-item', {
success: function(payload) {
var row;
if (payload._datagrid_redraw_item_class) {
row = $('tr[data-id=' + payload._datagrid_redraw_item_id + ']');
row = $('tr[data-id="' + payload._datagrid_redraw_item_id + '"]');
return row.attr('class', payload._datagrid_redraw_item_class);
}
}
Expand All @@ -902,7 +902,7 @@ dataGridRegisterExtension('datagrid.reset-filter-by-column', {
ref = payload.non_empty_filters;
for (i = 0, len = ref.length; i < len; i++) {
key = ref[i];
grid.find('[data-datagrid-reset-filter-by-column=' + key + ']').removeClass('hidden');
grid.find('[data-datagrid-reset-filter-by-column="' + key + '"]').removeClass('hidden');
}
href = grid.find('.reset-filter').attr('href');
return grid.find('[data-datagrid-reset-filter-by-column]').each(function() {
Expand Down

0 comments on commit 4613b83

Please sign in to comment.