Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for wrong display of toolbar & export buttons #1102

Merged
merged 1 commit into from
Oct 13, 2023
Merged

Fix for wrong display of toolbar & export buttons #1102

merged 1 commit into from
Oct 13, 2023

Conversation

elring
Copy link
Contributor

@elring elring commented Oct 12, 2023

See issue #1101

Summary

After commit 55fd8b4 the toolbar looks wrong:

image

  1. The buttons are without any space between - this is because of wrong CSS selector in datagrid.css - extra div is now needed - fixed by modifying CSS selector
  2. The export buttons are on new line - this is because of the new snippet div (the export toolbar is outside of it) - fixed by CSS property display of new div set to inline-block

After these changes, toolbar looks better:

image

@elring elring changed the title Fix for wring display of toolbar & export buttons Fix for wrong display of toolbar & export buttons Oct 12, 2023
@paveljanda paveljanda merged commit 3218e7e into contributte:master Oct 13, 2023
8 of 9 checks passed
@paveljanda
Copy link
Member

Thanks

@elring elring deleted the fixtoolbar branch October 13, 2023 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@elring @paveljanda