Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for content icons (Google Material etc) #739

Open
wants to merge 3 commits into
base: v5.x
Choose a base branch
from

Conversation

universe-42
Copy link

This future now support optional second argument for setIcon

$button->setIcon('material-icons', 'cloud_download');

Thats print

<a class="md-bnt" title="Download CSV" href="">
  <span class="material-icons">cloud_download</span>
  &nbsp;CSV
</a>

BC: no

(squash commits into one?)

@f3l1x
Copy link
Member

f3l1x commented Feb 24, 2019

cc @paveljanda ?

src/Traits/TButtonIcon.php Outdated Show resolved Hide resolved
@f3l1x
Copy link
Member

f3l1x commented Nov 24, 2021

ping @universe-42

@radimvaculik
Copy link
Member

@universe-42 Could you rebase the branch? Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants