-
Notifications
You must be signed in to change notification settings - Fork 791
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: expose parser and writer option overrides #896
base: master
Are you sure you want to change the base?
feat: expose parser and writer option overrides #896
Conversation
Previously, as shown in conventional-changelog#542, using both options at the same time resulted in the bump file's version being set to null. This was validated in the first of the new unit tests. The other unit tests simply check that the rest of the behavior is correct in this case. With this combination the user can override the version, the purpose of `release-as`, while still starting or continuing a pre-release, the purpose of of the `prerelease`. Fixes conventional-changelog#542
… this package starts at 9.5.0, this requirement is met)
feat(tag): add an option to force tag replacement
…ovate/actions-checkout-3.x chore(deps): update actions/checkout action to v3
…ovate/actions-setup-node-3.x chore(deps): update actions/setup-node action to v3
fix: Use relative path in git ignore
fix: Combining both release-as and prerelease now doesn't break package
fix: continue with commit when commitAll is true
…-version fix: print version number that updater.writeVersion returns
…to-git-tag-version fix: fallback to git tag if no version in package file
…ease-please--branches--master--components--commit-and-tag-version chore(master): release 9.6.0
…novate/mocha-10.x chore(deps): update dependency mocha to v10
…novate/mock-fs-5.x chore(deps): update dependency mock-fs to v5
…novate/yargs-17.x fix(deps): update dependency yargs to v17
…lease-please--branches--master--components--commit-and-tag-version chore(master): release 10.0.0
…lease-please--branches--master--components--commit-and-tag-version chore(master): release 10.0.1
Since this repository has been deprecated, maybe it's an idea to target this PR to the maintained fork? We need this feature as well :) if you don't feel like opening the PR I can also implement the changes but I don't want to steal your thunder ⚡ |
Great to see that somebody else is continuing this project, since I used it because I wasn't happy with It's especially nice to see that it looks like pact is at least loosely associated with it. Coincidentally, I used pact-js at a company a few years ago. Anyway, I'll try to get this done soon. 🙂 |
Plus, thanks for the opportunity to contribute myself rather than just copying my stuff, that's quite considerate. 🙂 |
Exposing these will resolve a number of issues where people want to customize something but don't want to create a full preset to replace the default one with.
Functionally, if these overrides aren't set, their value will obviously be
undefined
, making this change fully backwards compatible.Two examples about a simple sorting override:
Fixes #293
Fixes #869