Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow extending validation using project Makefile #1506

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

arunpoudel
Copy link
Contributor

@arunpoudel arunpoudel commented Dec 6, 2023

Note: Draft, DO NOT MERGE.

See for why.

Summary:
Allow projects to define their own Makefile target validate.
If the Makefile exists in the project using the devtool,
then after devtool's validate has run, run the project's
validate target.

@arunpoudel arunpoudel marked this pull request as draft December 6, 2023 08:22
(See)[./adrs/0001-extending-validation.md] for why.

Summary:
Allow projects to define their own Makefile target `validate`.
If the Makefile exists in the project using the devtool,
then after devtool's validate has run, run the project's
validate target.
@arunpoudel arunpoudel force-pushed the add-support-for-local-makefile-extension branch from 1e74063 to 3c2e9a6 Compare December 13, 2023 12:02
@arunpoudel
Copy link
Contributor Author

We will revisit this later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant