Skip to content

Port upstream PR #329: Hide CLI console window on Windows #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
krukow merged 3 commits into from
Feb 21, 2026
Merged

Port upstream PR #329: Hide CLI console window on Windows #28

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
812181e
Initial plan
Copilot Feb 21, 2026
d8140d8
Port upstream PR #329: hide CLI console window on Windows
Copilot Feb 21, 2026
181b092
Merge branch 'main' into copilot/port-upstream-pr-329
krukow Feb 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,9 @@ All notable changes to this project will be documented in this file. This change

## [Unreleased]

### Added (upstream PR #329 sync)
- Windows console window hiding: CLI process is spawned with explicit PIPE redirects ensuring the JVM sets `CREATE_NO_WINDOW` on Windows — no console window appears in GUI applications. Equivalent to upstream `windowsHide: true` (upstream PR #329).

### Changed
- Recommended default model for non-streaming examples is `claude-haiku-4.5` instead of `gpt-5.2` for faster response times

Expand Down
9 changes: 8 additions & 1 deletion src/github/copilot_sdk/process.clj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,14 @@
(when github-token
(.put env-map "COPILOT_SDK_AUTH_TOKEN" github-token)))

;; Configure stdio
;; Configure stdio — use explicit PIPE redirects for all three streams.
;; On Windows, the JVM's ProcessImpl sets CREATE_NO_WINDOW when none of the
;; child's stdio handles are inherited from the parent console. By ensuring
;; PIPE (not INHERIT) for stdin, stdout, and stderr, we guarantee no
;; console window appears — equivalent to upstream windowsHide: true (PR #329).
(.redirectInput builder ProcessBuilder$Redirect/PIPE)
(.redirectOutput builder ProcessBuilder$Redirect/PIPE)
(.redirectError builder ProcessBuilder$Redirect/PIPE)
(.redirectErrorStream builder false)

(let [process (.start builder)
Expand Down