Skip to content

Comments

Upstream sync: GitHubToken rename, sendAndWait cancellation fix, Foundry Local docs#148

Open
Copilot wants to merge 4 commits intomainfrom
copilot/update-upstream-sync-commits
Open

Upstream sync: GitHubToken rename, sendAndWait cancellation fix, Foundry Local docs#148
Copilot wants to merge 4 commits intomainfrom
copilot/update-upstream-sync-commits

Conversation

Copy link
Contributor

Copilot AI commented Feb 24, 2026

Ports 6 upstream commits from github/copilot-sdk (c4b3b36f0909a7).

Changes ported

GithubTokenGitHubToken rename (99c7c52)

  • New canonical methods: getGitHubToken() / setGitHubToken() on CopilotClientOptions
  • Old getGithubToken() / setGithubToken() retained as @Deprecated for backward compatibility
  • Error message updated: "GithubToken and UseLoggedInUser cannot be used...""GitHubToken..."
// New (preferred)
new CopilotClientOptions().setGitHubToken("gho_...");

// Old (still works, but deprecated)
new CopilotClientOptions().setGithubToken("gho_...");

sendAndWait cancellation fix (f0909a7)
Previously, calling cancel(true) on the returned CompletableFuture left the event subscription and timeout scheduler running (resource leak). Refactored to use an explicit result future: when cancelled externally, the inner future is cancelled too, triggering proper cleanup.

Microsoft Foundry Local docs (0e6561d)
Added Foundry Local to the BYOK provider table in advanced.md with setup instructions (dynamic port behavior, foundry model run, foundry service status).

Not ported

  • 5a9b475 — Node.js dependency bump, not applicable
  • eaf06cd — Node.js docs validation script fix, not applicable
  • dea514d.exe download timeout fix (NuGet packaging), Java SDK does not bundle CLI

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • checkstyle.org
    • Triggering command: /opt/hostedtoolcache/CodeQL/2.24.0/x64/codeql/tools/linux64/java/bin/java /opt/hostedtoolcache/CodeQL/2.24.0/x64/codeql/tools/linux64/java/bin/java -jar /opt/hostedtoolcache/CodeQL/2.24.0/x64/codeql/xml/tools/xml-extractor.jar --fileList=/home/REDACTED/work/copilot-sdk-java/.codeql-scratch/dbs/java/working/files-to-index2919233545206330813.list --sourceArchiveDir=/home/REDACTED/work/copilot-sdk-java/.codeql-scratch/dbs/java/src --outputDir=/home/REDACTED/work/copilot-sdk-java/.codeql-scratch/dbs/java/trap/java /@github/copilot-linux-x64/copilot ndor/bin/which (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Original prompt

This section details on the original issue you should resolve

<issue_title>[upstream-sync] 6 new commits (2026-02-24)</issue_title>
<issue_description>## Upstream Changes Detected

Commit count: 6 new commits since last merge
Upstream HEAD: f0909a7
Last merged: c4b3b36
Compare: c4b3b36...f0909a7

Recent Commits

  • f0909a7 [dotnet] Fix SendAndWaitAsync to throw OperationCanceledException on external cancellation (#543)
  • 5a9b475 chore(nodejs): bump @github/copilot from ^0.0.411 to ^0.0.414 (#542)
  • 99c7c52 fix: correct 'GithubToken' casing to 'GitHubToken' in .NET and Go (#541)
  • 0e6561d Document Microsoft Foundry Local setup and usage (#461)
  • eaf06cd fix: replace execSync with execFileSync in docs validation (#505)
  • dea514d Fix timeout issue when downloading the exe file (#533)

Instructions: Follow the agentic merge upstream prompt to port these changes to the Java SDK. Create a PR with the upstream-sync label when complete.

AI generated by Weekly Upstream Sync Agentic Workflow

  • expires on Mar 2, 2026, 9:35 AM UTC

Comments on the Issue (you are @copilot in this section)


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI and others added 3 commits February 24, 2026 09:48
… Foundry Local docs

Co-authored-by: brunoborges <129743+brunoborges@users.noreply.github.com>
Co-authored-by: brunoborges <129743+brunoborges@users.noreply.github.com>
Copilot AI changed the title [WIP] Update upstream changes with 6 new commits Upstream sync: GitHubToken rename, sendAndWait cancellation fix, Foundry Local docs Feb 24, 2026
@brunoborges brunoborges marked this pull request as ready for review February 24, 2026 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[upstream-sync] 6 new commits (2026-02-24)

2 participants