OUT-2866: check QBO account company is US or not #179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
- [x] add function that makes api request to intuit to fetch realm company info - [x] check if the QBO account company is non US - [x] if non US then show call out with copy: support US company only
SandipBajracharya
force-pushed
the
OUT-2866
branch
from
906d7d1 to
2b87efc
Compare
rrojan
approved these changes
Jan 19, 2026
priosshrsth
reviewed
Jan 19, 2026
priosshrsth
left a comment
priosshrsth
left a comment
There was a problem hiding this comment.
I don't have the full context. But here are my understandings:
- The feature we are building is only available in US.
- We are showing proper message to non US companies.
If that's the case,
- Could we fetch the companyInfo on serverSide?
- Rather than tracking isNonUseCompany, we can check companyInfo.Country === "US"
These are just my suggestions. But if we don't need company info anywhere else other than the flag to identify US, then I guess this is fine too.
Collaborator
Author
We are showing this Callout that is dependent on few client side logics. Fetching data in server side is good idea but might have to change the whole flow only for that. And also the company info is used for this particular callout only. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Testing Criteria