Skip to content

OUT-2955: create new income account if not found in QBO #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SandipBajracharya merged 3 commits into from
Jan 20, 2026
Merged

OUT-2955: create new income account if not found in QBO #186

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eaa6942
fix(OUT-2955): create new income account if not found in QBO
SandipBajracharya Jan 20, 2026
51d1926
fix(OUT-2955): rename income account copy
SandipBajracharya Jan 20, 2026
9468fd1
perf(OUT-2955): add optional chaining to avoid error
SandipBajracharya Jan 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 19 additions & 3 deletions src/app/api/quickbooks/auth/auth.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,15 +52,31 @@ export class AuthService extends BaseService {
}

async manageIncomeAccountRef(intuitApi: IntuitAPI): Promise<string> {
const incomeAccRef = await intuitApi.getSingleIncomeAccount()
const existingIncomeAccRef = await intuitApi.getSingleIncomeAccount()
if (existingIncomeAccRef) {
return existingIncomeAccRef?.Id
}

console.info(
`IntuitAPI#manageIncomeAccountRef | No existing income account found. Creating new one.`,
)

const payload = {
Name: 'Assembly SOP Income',
Classification: 'Revenue',
AccountType: 'Income',
AccountSubType: 'SalesOfProductIncome',
Active: true,
}
const incomeAccRef = await intuitApi.createAccount(payload)
return incomeAccRef.Id
}

async manageExpenseAccountRef(intuitApi: IntuitAPI): Promise<string> {
const accName = 'Assembly Processing Fees'
const existingAccount = await intuitApi.getAnAccount(accName)
if (existingAccount) {
return existingAccount.Id
return existingAccount?.Id
}

// Docs: https://developer.intuit.com/app/developer/qbo/docs/api/accounting/all-entities/account#the-account-object
Expand All @@ -79,7 +95,7 @@ export class AuthService extends BaseService {
const accName = 'Assembly General Asset'
const existingAccount = await intuitApi.getAnAccount(accName)
if (existingAccount) {
return existingAccount.Id
return existingAccount?.Id
}

/**
Expand Down
Loading