Skip to content

Conversation

@arpandhakal
Copy link
Collaborator

Changes

  • Added a layout of subtasks indicator card on task creation form with clear all button.
  • added a functionality of clear all button to trigger disableSubtaskTemplates creation on task create api. 
  • captured disabledSubtaskTemplates from search params on task create controller.

Testing Criteria

@linear
Copy link

linear bot commented Dec 15, 2025

@vercel
Copy link
Contributor

vercel bot commented Dec 15, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
tasks-app Ready Ready Preview, Comment Dec 18, 2025 1:38pm

@arpandhakal arpandhakal marked this pull request as ready for review December 15, 2025 13:56
@arpandhakal arpandhakal changed the title OUT-2759 | Show Subtasks count on create task modal while applying a template OUT-2759, OUT-2798 | Show Subtasks count on create task modal while applying a template Dec 16, 2025
@arpandhakal arpandhakal changed the base branch from OUT-2755 to feature/sub-templates December 16, 2025 12:37
- Added a layout of subtasks indicator card on task creation form with clear all button.
- added a functionality of clear all button to trigger disableSubtaskTemplates creation on task create api. 
- captured disabledSubtaskTemplates from search params on task create controller.
Copy link
Collaborator

@rrojan rrojan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🏆

const user = await authenticate(req)

const data = CreateTaskRequestSchema.parse(await req.json())
const disableSubtaskTemplates = req.nextUrl.searchParams.get('disableSubtaskTemplates') === 'true'
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets use getSearchParams instead

…tails page

- added OneTemplateDataFetcher HOC in template details page to invalidate the cache.
- prevented overriding the templates state if there are already some elements in the global templates state.
- Manage templates button on template options hidden when user is from notification center.
- added template fetcher on tasks details page so that user can access templates dropdown on notification-center-view
…gn fixes

- Sorted templates on templates board by createdAt. The rearrangement was caused because of updating redux store on hover.
- Removed extra line at the top of tempalte detail page.
…of having separate ones, memoized templats list
…of having separate ones, memoized templats list
- added manual timestamps for subtasks while creating them from a template with respect to parent templates createdAt.
- this process maintains that the subtasks are created parallely and in order which gives us both performance and ordering.
- found another issue where subtasks creation from templates causes race condition on realtime, causing update events to fire before create events for subtasks, causing duplicate data. Fixed this.
@arpandhakal arpandhakal merged commit bd54558 into feature/sub-templates Dec 18, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants