generated from pagevamp/copilot-custom-app-starter-kit
-
Notifications
You must be signed in to change notification settings - Fork 1
OUT-2759, OUT-2798 | Show Subtasks count on create task modal while applying a template #1062
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
effddf1 to
250aa81
Compare
- Added a layout of subtasks indicator card on task creation form with clear all button. - added a functionality of clear all button to trigger disableSubtaskTemplates creation on task create api. - captured disabledSubtaskTemplates from search params on task create controller.
c48a88c to
dbf94b4
Compare
rrojan
approved these changes
Dec 17, 2025
Collaborator
rrojan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🏆
| const user = await authenticate(req) | ||
|
|
||
| const data = CreateTaskRequestSchema.parse(await req.json()) | ||
| const disableSubtaskTemplates = req.nextUrl.searchParams.get('disableSubtaskTemplates') === 'true' |
Collaborator
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lets use getSearchParams instead
…tails page - added OneTemplateDataFetcher HOC in template details page to invalidate the cache. - prevented overriding the templates state if there are already some elements in the global templates state.
- Manage templates button on template options hidden when user is from notification center. - added template fetcher on tasks details page so that user can access templates dropdown on notification-center-view
…gn fixes - Sorted templates on templates board by createdAt. The rearrangement was caused because of updating redux store on hover. - Removed extra line at the top of tempalte detail page.
…of having separate ones, memoized templats list
…of having separate ones, memoized templats list
- added manual timestamps for subtasks while creating them from a template with respect to parent templates createdAt. - this process maintains that the subtasks are created parallely and in order which gives us both performance and ordering. - found another issue where subtasks creation from templates causes race condition on realtime, causing update events to fire before create events for subtasks, causing duplicate data. Fixed this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Testing Criteria