OUT-2804, OUT-2805 | CRM view manage-templates header breadcrumbs design issue #1064
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
rrojan
requested changes
Dec 17, 2025
src/utils/isRealtimePayloadEqual.ts
Outdated
Comment on lines
6
to
13
| export function isPayloadEqual( | ||
| payload: RealtimePostgresChangesPayload<RealTimeTaskResponse | RealTimeTemplateResponse>, | ||
| ): boolean { | ||
| const newPayload = payload.new | ||
| const oldPayload = payload.old | ||
| if (!newPayload || !oldPayload) return true | ||
| return deepEqual(newPayload, oldPayload) | ||
| } |
Collaborator
There was a problem hiding this comment.
It might be that all of the fields that we are interested in (e.g. title, description, workflow state) are not changed and something else is changed. Let's focus on checking for these important fields instead of directly checking deepEqual
arpandhakal
force-pushed
the
OUT-2799
branch
from
dc8b8ad to
2b6b352
Compare
arpandhakal
force-pushed
the
OUT-2804
branch
from
4d9213e to
c7c8684
Compare
- Manage templates button on template options hidden when user is from notification center. - added template fetcher on tasks details page so that user can access templates dropdown on notification-center-view
…gn fixes - Sorted templates on templates board by createdAt. The rearrangement was caused because of updating redux store on hover. - Removed extra line at the top of tempalte detail page.
…of having separate ones, memoized templats list
…of having separate ones, memoized templats list
- added manual timestamps for subtasks while creating them from a template with respect to parent templates createdAt. - this process maintains that the subtasks are created parallely and in order which gives us both performance and ordering. - found another issue where subtasks creation from templates causes race condition on realtime, causing update events to fire before create events for subtasks, causing duplicate data. Fixed this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes